Minor sound changes and clarity. #5088
Conversation
github-actions
bot
added
UI
|
I'm kinda split for either swoosh or tablehit1 for tableslams, but tableslam is pretty rare and the stun lasts for 10 seconds, so maybe a more noticeable sound like tablehit1 is warranted. I'm open to feedback of course. |
|
tablehit1 actually seems quite reasonable at the 25 setting, much more reasonable compared to playing the sound outside of byond |
aggressive grab floors you, so this would be the sound of you hitting the floor
|
before some maintainer comes along to tell you himself, rename the W M B G vars :) |
Disarm-stun is thudswoosh, passive-grab is thudswoosh, aggressive grab is thudswoosh... I don't think I can bring myself to add more, am gonna leave this alone for the moment, maybe it can be looked at in a separate PR or something. At least it's obvious from the animation when you carry them - whereas it's not super obvious when you passive or aggressive grab (there's slight animation but I feel like it can easily be missed in the heat of combat) |
|
mob_grab.dm is back to default as per the review - thanks |
My recommendation would be to consider looking at other code bases like TG which I believe has different icons in your hand depending on the grab type (e.g. the aggressive grab is a red hand) |
Drulikar
added
Grammar and Formatting
About the pull request
Adds the armorequip noise when backpack, uniform, shoes are unequipped. Changes the whoosh (disarm-stun) noise to only trigger when you stun someone. Adds sound to tablestun, and changes tablestun text to be more clear to new players that it stuns.
Explain why it's good for the game
In human vs human fights, sometimes your backpack/uniform/shoes get stolen. The armorequip sound is a good clue to draw attention to when this happens, both for the victim and the attacker, so adding it to a few more important gear pieces should be a benefit in these fringe cases. The effect is subtle enough, and the situation rare enough, that I don't think it would be too much. The whoosh sound is currently triggering when you "disarm" someone even when they are holding nothing in hand, which doesn't make sense. Now it's reserved for when a disarm-stun goes off. Swoosh sound added to tablestun, because tablestun being silent doesn't make sense. From my experience talking to players, tablestun is not very well known outside of veteran players who familiarized themselves with that niche interaction, so adding a sound and changing the text to make the effect clear should be a benefit.
Testing Photographs and Procedure
Screenshots & Videos
(https://www.youtube.com/watch?v=ElOAaq0dYcg&ab_channel=MK)
Changelog
🆑
spellcheck: tablestun text is more clear that it stuns
soundadd: unequip noise added to uniform, backpack, shoes.
soundadd: sound added to tablestun
sounddel: for disarms, whoosh only triggers on stun. otherwise, the miss sound plays
/:cl: